Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Karpenter default version to 0.37.0 #404

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

fabidick22
Copy link
Contributor

What does this PR do?

Update default version to v0.37.0

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@fabidick22 fabidick22 requested a review from a team as a code owner July 3, 2024 05:56
@bryantbiggs bryantbiggs changed the title chore(Karpenter): Update default version feat: Update Karpenter default version to 0.37.0 Jul 3, 2024
@bryantbiggs bryantbiggs merged commit 204cc1e into aws-ia:main Jul 3, 2024
7 checks passed
@fabidick22 fabidick22 deleted the patch-1 branch July 4, 2024 13:56
@ixolt
Copy link

ixolt commented Nov 4, 2024

We are encountering an error when applying the latest update:

"error": "launching nodeclaim, resolving ec2nodeclass, object is awaiting reconciliation"

This error is similar to what has been described in this related issue: aws/karpenter-provider-aws#6284.

Impacted Components

This issue also affects the latest version of the AWS EKS Blueprints Add-ons module:

source  = "aws-ia/eks-blueprints-addons/aws"
version = "1.18.3"

Any guidance or fixes related to this would be greatly appreciated.

@fabidick22
Copy link
Contributor Author

We are encountering an error when applying the latest update:

"error": "launching nodeclaim, resolving ec2nodeclass, object is awaiting reconciliation"

This error is similar to what has been described in this related issue: aws/karpenter-provider-aws#6284.

Impacted Components

This issue also affects the latest version of the AWS EKS Blueprints Add-ons module:

source  = "aws-ia/eks-blueprints-addons/aws"
version = "1.18.3"

Any guidance or fixes related to this would be greatly appreciated.

@ixolt If you have problems with that version of Karpenter, you can set a specific version:

module "eks_blueprints_addons" {
  source = "aws-ia/eks-blueprints-addons/aws"

  karpenter = {
    chart_version = "1.0.6"
  }
}

@ixolt
Copy link

ixolt commented Nov 7, 2024

There are manual steps required as per the documentation

kubectl annotate crd ec2nodeclasses.karpenter.k8s.aws \
  meta.helm.sh/release-name=karpenter-crd \
  meta.helm.sh/release-namespace=karpenter --overwrite

kubectl label crd ec2nodeclasses.karpenter.k8s.aws \
  app.kubernetes.io/managed-by=Helm --overwrite

kubectl annotate crd nodeclaims.karpenter.sh \
  meta.helm.sh/release-name=karpenter-crd \
  meta.helm.sh/release-namespace=karpenter --overwrite

kubectl label crd nodeclaims.karpenter.sh \
  app.kubernetes.io/managed-by=Helm --overwrite

kubectl annotate crd nodepools.karpenter.sh \
  meta.helm.sh/release-name=karpenter-crd \
  meta.helm.sh/release-namespace=karpenter --overwrite

kubectl label crd nodepools.karpenter.sh \
  app.kubernetes.io/managed-by=Helm --overwrite

and adding this helm release(only for version 0.37.+):

# CRD for Karpenter
resource "helm_release" "karpenter_crd" {
  name       = "karpenter-crd"
  repository = "oci://public.ecr.aws/karpenter"
  chart      = "karpenter-crd"
  version    = {...karpenter_version...} <-- same versions as defined in "aws-ia/eks-blueprints-addons/aws"   karpenter = { chart_version = XXX }
  namespace  = "karpenter"
  wait       = true
 }

upgrading to version 1.0.+ requires adding following:

resource "helm_release" "karpenter_crd" {
 name       = "karpenter-crd"
 repository = "oci://public.ecr.aws/karpenter"
 chart      = "karpenter-crd"
 version    = {...karpenter_version...} <-- same versions as defined in "aws-ia/eks-blueprints-addons/aws"   karpenter = { chart_version = XXX }
 namespace  = "karpenter"
 wait       = true

 set {
   name  = "webhook.enabled"
   value = true
 }
 set {
   name  = "webhook.serviceName"
   value = "karpenter"
 }
 set {
   name  = "webhook.port"
   value = 8443
 }
}

cc #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants